NETOBSERV-1190: use DNS latency instead of timestamps #356

msherif1234 · 2023-07-14T16:17:40Z

lots of dependencies that need to be merged before we get to this PR
we need https://github.com/netobserv/network-observability-operator/pull/395and its dependencies merged then
#355

openshift-ci-robot · 2023-07-14T16:17:44Z

@msherif1234: This pull request references NETOBSERV-1190 which is a valid jira issue.

In response to this:

lots of dependencies that need to be merged before we get to this PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-07-14T16:19:13Z

@msherif1234: This pull request references NETOBSERV-1190 which is a valid jira issue.

In response to this:

lots of dependencies that need to be merged before we get to this PR
we need https://github.com/netobserv/network-observability-operator/pull/395and its dependencies merged then
#355

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

msherif1234 · 2023-07-14T16:20:11Z

/ok-to-test

codecov · 2023-07-14T16:22:39Z

Codecov Report

Merging #356 (1fc4837) into main (e6d08c3) will decrease coverage by 1.22%.
The diff coverage is 56.00%.

@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   58.61%   57.39%   -1.22%     
==========================================
  Files         151      155       +4     
  Lines        6635     7065     +430     
  Branches      804      863      +59     
==========================================
+ Hits         3889     4055     +166     
- Misses       2524     2768     +244     
- Partials      222      242      +20

Flag	Coverage Δ
uitests	`59.06% <66.45%> (+0.14%)`	⬆️
unittests	`52.71% <37.07%> (-5.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/handler/lokiclientmock/loki_client_mock.go	`0.00% <0.00%> (ø)`
pkg/model/fields/fields.go	`100.00% <ø> (ø)`
web/src/api/ipfix.ts	`100.00% <ø> (ø)`
web/src/api/loki.ts	`100.00% <ø> (ø)`
web/src/components/__tests-data__/config.ts	`100.00% <ø> (ø)`
...components/dropdowns/overview-display-dropdown.tsx	`68.42% <ø> (ø)`
web/src/components/dropdowns/scope-dropdown.tsx	`31.81% <ø> (ø)`
...components/dropdowns/topology-display-dropdown.tsx	`47.36% <ø> (ø)`
web/src/components/filters/filters-toolbar.tsx	`59.18% <ø> (ø)`
web/src/components/metrics/histogram.tsx	`16.51% <ø> (ø)`
... and 42 more

... and 1 file with indirect coverage changes

msherif1234 · 2023-07-14T16:40:52Z

/ok-to-test

github-actions · 2023-07-14T16:45:48Z

New image:
quay.io/netobserv/network-observability-console-plugin:f27bdf2

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=f27bdf2 make set-plugin-image

github-actions · 2023-07-17T07:43:07Z

New image:
quay.io/netobserv/network-observability-console-plugin:6aa630f

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=6aa630f make set-plugin-image

jotak

Some stuff to change, but I guess that @jpinsonneau will take over this PR anyway

web/src/components/netflow-record/record-field.tsx

web/src/utils/dns.ts

msherif1234 · 2023-07-17T12:01:45Z

Some stuff to change, but I guess that @jpinsonneau will take over this PR anyway

we can get this in and when @jpinsonneau comes back he will take it from here and add the additional pieces

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

github-actions · 2023-07-17T12:48:05Z

New image:
quay.io/netobserv/network-observability-console-plugin:a48378c

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=a48378c make set-plugin-image

github-actions · 2023-07-17T12:54:28Z

New image:
quay.io/netobserv/network-observability-console-plugin:9264e6b

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=9264e6b make set-plugin-image

jotak · 2023-07-17T13:01:38Z

web/src/utils/dns.ts

+  //{ value: 9, name: 'NotAuth', description: 'Server Not Authoritative for zone' },
+  { value: 9, name: 'NotAuth', description: 'Not Authorized' },
+  { value: 10, name: 'NotZone', description: 'Name not contained in zone' },
+  //{ value: 11, name: 'DSOTYPENI', description: 'DSO-TYPE Not Implemented' },


out of curiosity, why are DSOTYPENI and BADSIG commented out?

https://datatracker.ietf.org/doc/html/rfc2929#section-2.3

jotak · 2023-07-17T14:13:58Z

/lgtm

jotak · 2023-07-17T14:21:41Z

/approve

openshift-ci · 2023-07-17T14:21:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the jira/valid-reference label Jul 14, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 14, 2023

msherif1234 force-pushed the dns_latecny branch from 8a1d572 to 313d810 Compare July 14, 2023 16:37

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 14, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 14, 2023

msherif1234 force-pushed the dns_latecny branch from 313d810 to 4e0695a Compare July 14, 2023 19:01

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 14, 2023

msherif1234 force-pushed the dns_latecny branch from 4e0695a to c6780d4 Compare July 14, 2023 21:32

jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 17, 2023

jotak requested changes Jul 17, 2023

View reviewed changes

web/src/components/netflow-record/record-field.tsx Show resolved Hide resolved

web/src/utils/dns.ts Outdated Show resolved Hide resolved

openshift-ci bot assigned jotak Jul 17, 2023

msherif1234 force-pushed the dns_latecny branch from c6780d4 to edafb0a Compare July 17, 2023 11:59

openshift-merge-robot added the needs-rebase label Jul 17, 2023

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 17, 2023

msherif1234 requested a review from jotak July 17, 2023 12:00

jpinsonneau added 7 commits July 17, 2023 08:10

PoC packet loss

3f1273d

renamed Dropped -> TcpDrop

5c2042c

fix errors and tests

e1d4d7f

add interface field & filter

5a64637

updated mocks

fe1a035

overview & topology

4e1e6e8

dropped donuts

2dec416

jpinsonneau added 11 commits July 17, 2023 08:10

remove tcp drop enums

1a87858

removed unused field

991809d

drops filter renaming

3442611

reuse lineFilters

dbc38e1

strict match on key

eaac85f

updated sent filter to match description

f1dd55b

aggregateBy

2408676

avoid divide by 0

0df2610

rebase fix

202797a

dns response code + optionnal fields

cff3a93

update examples

5e94cc3

msherif1234 force-pushed the dns_latecny branch from edafb0a to 7e441e4 Compare July 17, 2023 12:10

openshift-merge-robot removed the needs-rebase label Jul 17, 2023

jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 17, 2023

NETOBSERV-1190: use DNS latency instead of timestamps

1fc4837

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

msherif1234 force-pushed the dns_latecny branch from 7e441e4 to 1fc4837 Compare July 17, 2023 12:44

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 17, 2023

jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 17, 2023

jotak reviewed Jul 17, 2023

View reviewed changes

msherif1234 requested a review from jotak July 17, 2023 13:32

openshift-ci bot added the lgtm label Jul 17, 2023

openshift-ci bot added the approved label Jul 17, 2023

openshift-merge-robot merged commit 2003ce5 into netobserv:main Jul 17, 2023

This was referenced Jul 17, 2023

NETOBSERV-1186 DNS respond codes #355

Closed

NETOBSERV-1064: TCP drop & DNS tracking #324

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NETOBSERV-1190: use DNS latency instead of timestamps #356

NETOBSERV-1190: use DNS latency instead of timestamps #356

msherif1234 commented Jul 14, 2023 •

edited

Loading

openshift-ci-robot commented Jul 14, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jul 14, 2023 •

edited by openshift-ci bot

Loading

msherif1234 commented Jul 14, 2023

codecov bot commented Jul 14, 2023 •

edited

Loading

msherif1234 commented Jul 14, 2023

github-actions bot commented Jul 14, 2023

github-actions bot commented Jul 17, 2023

jotak left a comment

msherif1234 commented Jul 17, 2023

github-actions bot commented Jul 17, 2023

github-actions bot commented Jul 17, 2023

jotak Jul 17, 2023

msherif1234 Jul 17, 2023

jotak commented Jul 17, 2023

jotak commented Jul 17, 2023

openshift-ci bot commented Jul 17, 2023

NETOBSERV-1190: use DNS latency instead of timestamps #356

NETOBSERV-1190: use DNS latency instead of timestamps #356

Conversation

msherif1234 commented Jul 14, 2023 • edited Loading

openshift-ci-robot commented Jul 14, 2023 • edited by openshift-ci bot Loading

openshift-ci-robot commented Jul 14, 2023 • edited by openshift-ci bot Loading

msherif1234 commented Jul 14, 2023

codecov bot commented Jul 14, 2023 • edited Loading

Codecov Report

msherif1234 commented Jul 14, 2023

github-actions bot commented Jul 14, 2023

github-actions bot commented Jul 17, 2023

jotak left a comment

Choose a reason for hiding this comment

msherif1234 commented Jul 17, 2023

github-actions bot commented Jul 17, 2023

github-actions bot commented Jul 17, 2023

jotak Jul 17, 2023

Choose a reason for hiding this comment

msherif1234 Jul 17, 2023

Choose a reason for hiding this comment

jotak commented Jul 17, 2023

jotak commented Jul 17, 2023

openshift-ci bot commented Jul 17, 2023

msherif1234 commented Jul 14, 2023 •

edited

Loading

openshift-ci-robot commented Jul 14, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jul 14, 2023 •

edited by openshift-ci bot

Loading

codecov bot commented Jul 14, 2023 •

edited

Loading